-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silent disconnect when a handler throws #786
Comments
Repro: Steam.Instance.Apps.PICSGetAccessTokens(new System.Collections.Generic.List<uint>() { 440, 440 }, Enumerable.Empty<uint>()); EDIT: I created #787 to fix the exception in the handler. However if a handler throws, it shouldn't just eat it into debuglog and silently disconnect. This needs to be improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SteamKit/SteamKit2/SteamKit2/Steam/SteamClient/SteamClient.cs
Lines 384 to 385 in 58562fc
I couldn't figure out what was happening last time this happened because it silently logs the exception into the debug log (with no stacktrace) and just disconnects.
This time I had debug log enabled and got this:
After that, SK2 started to constantly keep disconnecting with the same message (but without freelicense grant this time). Which eventually got me rate limited by the CM.
The text was updated successfully, but these errors were encountered: