Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add guaranteed time available for finish onDismount method in frontend #612

Open
3 tasks done
steam3d opened this issue Apr 5, 2024 · 3 comments
Open
3 tasks done
Labels
feature request a request for a feature, no guarantee of addition

Comments

@steam3d
Copy link

steam3d commented Apr 5, 2024

Please confirm

  • I have searched existing issues
  • This issue is not a duplicate of an existing one
  • This is not a request for a plugin

Feature Request Description

Some plugins must finish their background work before start them again. In cases: update, reload.

I suggest adding deferral parameter in OnDismount method that will give plugins fixed time like 1 second to stop their background job before Decky will run them again.

Further Description

No response

@steam3d steam3d added the feature request a request for a feature, no guarantee of addition label Apr 5, 2024
@AAGaming00
Copy link
Member

better option is to make onDismount async (if it isn't already?) and await it

@RodoMa92
Copy link
Contributor

RodoMa92 commented Apr 5, 2024

better option is to make onDismount async (if it isn't already?) and await it

I agree. It seems that it's not the default behaviour right now from a quick glance.

@steam3d
Copy link
Author

steam3d commented Apr 5, 2024

The Decky simple calls:

plugin.onDismount?.();

onDismount?(): void;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request a request for a feature, no guarantee of addition
Projects
None yet
Development

No branches or pull requests

3 participants