Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Can you add candleHeightScale, onCurrentProgress change? #23

Closed
ntxl1210 opened this issue Apr 27, 2024 · 0 comments · Fixed by #27
Closed

[enhancement] Can you add candleHeightScale, onCurrentProgress change? #23

ntxl1210 opened this issue Apr 27, 2024 · 0 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@ntxl1210
Copy link

I noticed you set a fixed scale value for candle height to 3. Could you add a prop to change this value? And if possible, could you also add a prop like onCurrentProgressChange or some props so that I can get currentProgress and songDuration through these props?

example: in Waveform component

useEffect(() => {
        onCurrentProgressChange?.(currentProgress, songDuration);
    }, [currentProgress, songDuration])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants