Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UNT-T24863: added onChangeWaveformLoadState prop #28

Merged
merged 1 commit into from
May 9, 2024
Merged

feat: UNT-T24863: added onChangeWaveformLoadState prop #28

merged 1 commit into from
May 9, 2024

Conversation

nilesh-simform
Copy link
Contributor

@nilesh-simform nilesh-simform commented May 3, 2024 •
edited

  • Added onWaveformLoadStateChange prop to get the current loading state of waveform( true - loading waveform, false - finished loading of waveform )
Screen.Recording.2024-05-03.at.4.35.25.PM.mov

@nilesh-simform nilesh-simform self-assigned this May 3, 2024
kuldip-simform
kuldip-simform requested changes May 3, 2024
View reviewed changes
src/components/Waveform/WaveformTypes.ts Outdated Show resolved Hide resolved
src/components/Waveform/Waveform.tsx Outdated Show resolved Hide resolved
@nilesh-simform nilesh-simform force-pushed the feature/UNT-T24863_add_loading_information branch 2 times, most recently from 6ca480c to 61dc807 Compare May 3, 2024 10:23
kuldip-simform
kuldip-simform previously approved these changes May 3, 2024
View reviewed changes
kuldip-simform
kuldip-simform reviewed May 3, 2024
View reviewed changes
example/src/App.tsx Outdated Show resolved Hide resolved
@kuldip-simform kuldip-simform self-requested a review May 3, 2024 10:48
@nilesh-simform nilesh-simform force-pushed the feature/UNT-T24863_add_loading_information branch from 61dc807 to d16e1af Compare May 3, 2024 11:10
kuldip-simform
kuldip-simform previously approved these changes May 3, 2024
View reviewed changes
@nilesh-simform nilesh-simform force-pushed the feature/UNT-T24863_add_loading_information branch from d16e1af to bf9faee Compare May 7, 2024 07:11
kuldip-simform
kuldip-simform previously approved these changes May 8, 2024
View reviewed changes
mukesh-simform
mukesh-simform reviewed May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
mukesh-simform
mukesh-simform reviewed May 8, 2024
View reviewed changes
example/src/App.tsx Outdated Show resolved Hide resolved
@nilesh-simform nilesh-simform force-pushed the feature/UNT-T24863_add_loading_information branch from bf9faee to d24791f Compare May 9, 2024 05:27
@nilesh-simform nilesh-simform force-pushed the feature/UNT-T24863_add_loading_information branch from d24791f to 4520845 Compare May 9, 2024 05:43
@nilesh-simform nilesh-simform changed the title feat: UNT-T24863: added onWaveformLoadStateChange prop feat: UNT-T24863: added onChangeWaveformLoadState prop May 9, 2024
@mukesh-simform mukesh-simform linked an issue May 9, 2024 that may be closed by this pull request
Loading information ? #22
Closed
@mukesh-simform mukesh-simform merged commit 7be3c3b into develop May 9, 2024
@mukesh-simform mukesh-simform deleted the feature/UNT-T24863_add_loading_information branch May 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukesh-simform mukesh-simform mukesh-simform approved these changes

@kuldip-simform kuldip-simform kuldip-simform left review comments

Assignees

@nilesh-simform nilesh-simform

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading information ?
3 participants
@nilesh-simform @mukesh-simform @kuldip-simform