Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload_tag not working with font_url filter #753

Open
adictonator opened this issue Dec 19, 2023 · 0 comments
Open

preload_tag not working with font_url filter #753

adictonator opened this issue Dec 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@adictonator
Copy link

Describe the bug
Using font_url in the preload_tag filter to preload font assets throws an error in theme editor.

Expected

The preload_tag filter should work with the font_url and not just asset_url.

Actual

Upon converting the <link> tag with the preload_tag filter, the Liquid error starts to show up in the theme editor.

Stack trace
This is the error you see in the theme editor at the top.

Liquid error (layout/theme line 24): Input must be a theme or shop asset URL

Debugging information

  • OS: Windows and Mac
  • Version: 1.11.0

Additional context

image

@adictonator adictonator added the bug Something isn't working label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant