Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Theme check doesn't detect missing translations for schema #730

Open
2 tasks done
bmandl opened this issue Apr 3, 2023 · 2 comments
Open
2 tasks done

[Bug]: Theme check doesn't detect missing translations for schema #730

bmandl opened this issue Apr 3, 2023 · 2 comments

Comments

@bmandl
Copy link

bmandl commented Apr 3, 2023

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Identifies missing or additional translations in locale files.

Actual behavior

Missing translations not found and no errors reported.
Actual output:

279 files inspected, 0 offenses detected, 0 offenses auto-correctable

Verbose output

2023-04-03T20:14:57.484Z: Running command theme check
  shopify:theme:check init version: @oclif/[email protected] argv: [ '-c', 'translation', '--verbose' ] +0ms
2023-04-03T20:14:57.511Z:
Running system process:
  · Command: ruby -v
  · Working directory: /home/bmandl/shopify/dawn

2023-04-03T20:14:57.586Z:
Running system process:
  · Command: bundle -v
  · Working directory: /home/bmandl/shopify/dawn

2023-04-03T20:14:57.853Z: Reading the content of file at ../../.nvm/versions/node/v18.12.1/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/Gemfile...
2023-04-03T20:14:57.861Z:
Running system process:
  · Command: bundle install
  · Working directory: /home/bmandl/.nvm/versions/node/v18.12.1/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby

2023-04-03T20:14:58.416Z:
Running system process:
  · Command: bundle exec ruby /home/bmandl/.nvm/versions/node/v18.12.1/lib/node_modules/@shopify/theme/node_modules/@shopify/cli-kit/assets/cli-ruby/bin/shopify theme check . --category translation --output text
  · Working directory: .

Checking . ...
279 files inspected, 0 offenses detected, 0 offenses auto-correctable
2023-04-03T20:15:01.769Z: Failed to report usage analytics: Couldn't find a a package.json traversing directories from /home/bmandl/shopify/dawn
2023-04-03T20:15:01.770Z: Completed command theme check

Reproduction steps

  1. Add some new translation in en.default.schema.json file
  2. run shopify theme check --category translation in theme folder

Operating System

wsl2 with Ubuntu 20.04 running on Windows 10

Shopify CLI version (check your project's package.json if you're not sure)

3.44.1

Shell

wsl2 - Ubuntu 20.04

Node version (run node -v if you're not sure)

v18.12.1

What language and version are you using in your application?

Ruby 3.0.6p216, Node.js v18.12.1

@alvaro-shopify
Copy link

Hi @bmandl . Thanks for rising up this issue!. Let me ping @Shopify/theme-developer-tools so they can take a look at ir

@github-actions
Copy link

github-actions bot commented May 6, 2023

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

@karreiro karreiro transferred this issue from Shopify/cli May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants