New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for nested liquid loops #337

Open

darryn opened this issue Jul 1, 2021 · 1 comment · May be fixed by #719

Labels

Projects

Performance by default

darryn commented Jul 1, 2021

There are instances where there are multiple liquid loops nested inside each other. These can clog the TTR.

Here is a bad example...

  {% for product in collection.products %}
    {% for tag in product.tags %}
      {% for variant in product.variants %}
        {% for collection in product.collections %}
        
        {% endfor %}
      {% endfor %}
    {% endfor %}
  {% endfor %}

Semi-related to the nested snippets logic.

macournoyer added the performance label

Contributor

macournoyer commented Jul 5, 2021

Oh this is good Darryn! Thanks for the suggestion.

charlespwd added this to To Do in Performance by default

Darhazer linked a pull request

that will close this issue

Add new NestedLoop check #719

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment