Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The AssetPreload check suggests using preload_tag on font_url assets, which is not supported #634

Open
nikitaourazbaev opened this issue Aug 30, 2022 · 2 comments · May be fixed by #716
Open

The AssetPreload check suggests using preload_tag on font_url assets, which is not supported #634

nikitaourazbaev opened this issue Aug 30, 2022 · 2 comments · May be fixed by #716
Labels
bug Something isn't working

Comments

@nikitaourazbaev
Copy link

Describe the bug
The AssetPreload check suggests using the preload_tag tag for a font url but preload_tag does not support font_url

Expected
The AssetPreload check should not suggest using preload_tag when the asset’s URL is not supported

Actual
The AssetPreload check suggests using preload_tag when the asset’s URL is not supported

Stack trace
N/A

Debugging information

  • OS Mac
  • Version 1.11.0

Additional context
CleanShot 2022-08-30 at 11 40 43@2x
@nikitaourazbaev nikitaourazbaev added the bug Something isn't working label Aug 30, 2022
@charlespwd
Copy link
Contributor

Reminds me that's a platform bug that I have to fix.

@bertiful
Copy link

bertiful commented Nov 2, 2022

Is Shopify able to support font URLs as part of the preload_tag? Ideally this can be done:

{%- liquid
  unless settings.heading_font.system?
    echo settings.heading_font | font_url | preload_tag: as: 'font', type: 'font/woff2', crossorigin: ''
  endunless
-%}

@eloyesp eloyesp linked a pull request Feb 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip font preload warning eloyesp/theme-check
3 participants
@bertiful @charlespwd @nikitaourazbaev