You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug / Actual
π Global objects used with paginate are suggested β¦
π β¦ but attributes of a specific object are not suggested.
Expected
Attributes of specific objects (e.g. customer.orders) should be suggested too.
Debugging information
OS: macOS
Version: 1.12.0
Additional context Liquid::Template.parse(markup) in VariableLookupFinder will raise an error, as it doesn't know paginate.
This problem could be solved with TolerantParser::Template.parse(markup).
However, the resulting tag is much "lighter" and might not contain all the relevant information.
In the screenshot, you see the debug output of paginate customer.orders vs. echo customer.orders.
### WHY are these changes introduced?
Fixes#683
### WHAT is this pull request doing?
Treats `paginate` in a similar way as `echo`, so that suggestions are shown.
Use cases like `{% paginate customer.orders` will be treated in #687.
Describe the bug / Actual
π Global objects used with
paginate
are suggested β¦π β¦ but attributes of a specific object are not suggested.
Expected
Attributes of specific objects (e.g.
customer.orders
) should be suggested too.Debugging information
Additional context
Liquid::Template.parse(markup)
inVariableLookupFinder
will raise an error, as it doesn't knowpaginate
.This problem could be solved with
TolerantParser::Template.parse(markup)
.However, the resulting tag is much "lighter" and might not contain all the relevant information.
In the screenshot, you see the debug output of
paginate customer.orders
vs.echo customer.orders
.Outsourced from #683
The text was updated successfully, but these errors were encountered: