-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cropped images in srcset using image_tag #1765
Comments
+1 for this. I expected the same, and ended up having to switch to an HTML img tag for fine tuning responsive image sizes. |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if this is the right repo to post this bug so do let me know if it should be filed elsewhere.
If you specify a crop for an image with image_url and try and feed that into the image_tag, the generated srcset images always contain your original fixed height. For example:
Each image that gets generated in the srcset will have height of 416 - so 54 x 416, 74 x 416, 104 x 416 and so on.
The images generated should take into account the aspect ratio - 54 x 54, 74 x 74 etc.
Also detailed here by another user: https://community.shopify.com/c/technical-q-a/image-tag-how-do-i-get-cropped-images-into-a-srcset/td-p/1472242.
The text was updated successfully, but these errors were encountered: