-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: support pass unique key to Keeper #25
Comments
Hi echo, thanks for your proposal, basically I agree with it.
however, support a new way to generate id is LGTM. I think we can decouple id generator:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, first of all thank you for the library!
In the process of trying to use it, we found that because the worker's unique id is achieved through sonyflake, the worker requires an integer between 0 and 255 to achieve the unique id when it is started
fastflow/keeper/keeper.go
Line 14 in 1afa592
In practice, this restriction would lead to reliance on external storage to generate the unique integer in multi-process situations, so I propose that the global unique key can be passed directly from the caller and the keeper component no longer generates the unique key based on number
There are two advantages to this change
If you agree to this change, I will provide PR in my free time
thanks
The text was updated successfully, but these errors were encountered: