Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Issues found #192

Open
KanzakiYui opened this issue May 15, 2019 · 0 comments
Open

Several Issues found #192

KanzakiYui opened this issue May 15, 2019 · 0 comments

Comments

@KanzakiYui
Copy link

KanzakiYui commented May 15, 2019

I found the following facts:

  1. onChange will be called every time the dropdown menu is closed, even if the value isn't changed, especially when multiple=false
  2. checkedIcon and unCheckedIcon is not available when multiple=false
  3. There is no DefaultValue option especially when multiple=false

Thus, it causes a problem I found when multiple=false and select the option which is already selected:
(1) onChange will be called
(2) function assigned to value will NOT be called, which means value will not be re-calculated
(3) function selectionsRenderer will be called while the 1st param (value) is null. However,
it should be the previous value (if applicable) when user select the selected option, since when multiple=false, there is no checked/unchecked conception behind. And this supposed behavior can be found in browsers' default single dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant