-
Notifications
You must be signed in to change notification settings - Fork 79
Return status for inc_backup() is IGNORED !? #430
Comments
:( sorry for the bad experience, in fact, most of the code base has been refactored for release_v2.0. I have implemented docker container runs, API calls, etc. |
Not as a py code because i have never used py as a developer.... What i suggest: That may have impact to some workflow, but better a runtime exception then a false positive result. regards |
Indeed, proper error handling related to exit codes should be applied here as well. |
found another "worst case" scenario (same bug pattern) for full backup: the follwoing line is not respecting the result from line 703!
basically i was able to do a full backup and a incremental backup both with false positive end status :-( |
@WernerMairl As I have released version 2.0, this error should not be encountered anymore. |
Hi
you are ignoring the result (0/1) for inc_backup(), the entire autoxtrbackup run results in a false positive exitcode!
That may not be the best practice :-(
MySQL-AutoXtraBackup/master_backup_script/backuper.py
Line 753 in 72ca0a8
MySQL-AutoXtraBackup/master_backup_script/backuper.py
Line 760 in 72ca0a8
impact: i got some error in the next run of autoxtrabackup during preparation.... but it was really hard to find out that the root cause was in the backup before with a false positive exit :-(
regards
Werner
The text was updated successfully, but these errors were encountered: