-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] checkver.ps1
wrongly shows URL not valid
when disconnected
#5891
Labels
Comments
Possible Solutioni understand that the condition / trigger for showing invalid url might very well be valid, or a more aware check might be hard to implement. so, a check should be made before actually using the url to ensure if connected to internet. if not, then it should gracefully exit right there and skip using / commenting on url altogether. but the problem with this can be that it won't work with local urls/full filenames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Current Behavior
when the system is not connected to internet, the
scoop/bin/checkver.ps1
saysURL ... is not valid
Expected Behavior
it should have said disconnected, or not connected, or unable to connect or the like.
but never "URL invalid" in such case
Additional context/output
Possible Solution
shared in first comment below to keep it separate
System details
The text was updated successfully, but these errors were encountered: