-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBO always returns retcode Failure #745
Labels
bug
Something isn't working
Comments
We'd need to change these to the retcodes of SciML. In the meantime, it would be good to change this to Default. |
ParasPuneetSingh
added a commit
to ParasPuneetSingh/Optimization.jl
that referenced
this issue
May 29, 2024
The comment edit needs to be performed in SciMLBase and other solver packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug 馃悶
BBO optimisers always have a
retcode=SciMLBase.ReturnCode.Failure
.Minimal Reproducible Example 馃憞
Output鈿狅笍
The string
stop_reason
given by BBO indicates convergence to requested threshold, but theretcode
is stillFailure
.Environment (please complete the following information):
using Pkg; Pkg.status()
using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
versioninfo()
Additional context
The issues seems to be that OptimizationBBO takes the
stop_reason
string, converts it to aSymbol
, and passes it asretcode
here:Optimization.jl/lib/OptimizationBBO/src/OptimizationBBO.jl
Line 188 in 1877aea
but SciMLBase has the fallback behavior of returning
Failure
when it doesn't recognise theSymbol
:https://github.com/SciML/SciMLBase.jl/blob/541e7fd132f8029c0ef8c1af26eefa6314810a03/src/retcodes.jl#L407
If parsing the strings returned by BBO is too much trouble then maybe returning
ReturnCode.Default
would be less misleading.The text was updated successfully, but these errors were encountered: