Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better thread safety for callbacks when solving for Trajectories. #28

Merged
merged 1 commit into from
May 4, 2021

Conversation

dpad
Copy link
Owner

@dpad dpad commented May 4, 2021

Automatically copies callbacks provided when solving a State (to get a Trajectory). This fixes some simpler thread safety issues (e.g. when using States within an EnsembleProblem).

Fixes SciML/DiffEqCallbacks.jl#99.

@dpad dpad enabled auto-merge May 4, 2021 06:51
@dpad dpad merged commit 1ce6e96 into master May 4, 2021
@dpad dpad deleted the fix/thread-safe-state-callbacks branch May 4, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeriodicCallback is seemingly not thread-safe in EnsembleProblem with EnsembleThreads
1 participant