Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of horizontal Lines incompatible with dark Mode #47

Closed
Mavoort opened this issue May 6, 2024 · 1 comment · Fixed by #48
Closed

Color of horizontal Lines incompatible with dark Mode #47

Mavoort opened this issue May 6, 2024 · 1 comment · Fixed by #48
Assignees

Comments

@Mavoort
Copy link
Contributor

Mavoort commented May 6, 2024

On a web page with white text and a dark background ("dark mode"), the pseudocode block looks a bit strange.

In particular, the horizontal lines remain black, even though the text and the vertical lines are white.

pseudocode_bug-black_lines

To fix this, I suggest replacing

border: 2px solid black;

inside of pseudocode.css with:

border-width: 2px;
border-style: solid;

This way you could use pseudocode.js also on a dark website.

@SaswatPadhi
Copy link
Owner

Thanks for reporting this issue, @Mavoort!

I have reviewed your changes and left some minor comments. I've also linked your PR to this bug so this issue will be closed automatically when we merge your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants