-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bake setup breaks PATH on windows #89
Comments
ZeroErrors
added a commit
to ZeroErrors/bake
that referenced
this issue
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment when installing bake this bit of code runs during the setup process to try and add the bake directory to the PATH environment variable. It does this by creating a
.bat
file that usessetx
to set the PATH environment variable to the content of the current PATH variable (stored inBAKE_USERPATH
which is crated by the setup script) and combines it with the bake directory.There are a couple issues with this.
PATH
contents to get copied into the local userPATH
variable.Since the user and system
PATH
are just appended together this duplicates the content if the setup script is run more than once.setx
has a limit of 1024 characters and it will truncate the string meaning you can lose paths previously in the localPATH
variable(see: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/setx#remarks)
The correct way to do this is to modify the values in the registry to fetch the current local user
PATH
variable, append the bake path and then set the usersPATH
variable in the registry again.I think temporarily it would be ideal to disable this functionality as it can break users environments.
The text was updated successfully, but these errors were encountered: