Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space at the end of certain tests #41

Open
Samyak2 opened this issue Jul 1, 2022 · 0 comments
Open

Extra space at the end of certain tests #41

Samyak2 opened this issue Jul 1, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Samyak2
Copy link
Owner

Samyak2 commented Jul 1, 2022

What?

Some tests automatically end as soon as you enter the last character but some others will require you to press space following the last word in order to end.

Context

This case was explicitly handled here:

toipe/src/tui.rs

Lines 407 to 411 in 063fc4f

// last line wasn't added in loop
// last line doesn't have an extra space at the end
// - the typing test stops as soon as the user types last char
// - won't hang there waiting for user to type space
lines.push(Text::from(line.join(" ")).with_faint());

I'm not sure why it still causes an issue.

Originally reported by user "Merulox" in a YouTube comment (I did not find a way to link to a comment directly).

@Samyak2 Samyak2 added the bug Something isn't working label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant