fix(card): ensure that focus outline wraps all card content when height prop is set
#6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipperTheDan
previously approved these changes
May 23, 2024
nuria1110
previously approved these changes
May 24, 2024
…ght` prop is set Ensures that the card content has a responsive height so the focus styles wrap all of the interactive area of the content when the `Card` has a `height` prop passed fix #6741
edleeks87
force-pushed
the
card-focus-style-fix-FE-6584
branch
from
9e208d8
to
5b73495
Compare
DipperTheDan
approved these changes
May 24, 2024
nuria1110
approved these changes
May 24, 2024
ZhuoyuJin
approved these changes
May 29, 2024
|
🎉 This PR is included in version 136.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6741
Proposed behaviour
Ensures that the card content has a responsive height so the focus styles wrap all of the interactive area of the content when the
Cardhas aheightprop passedCurrent behaviour
Content is not responsive when
heightprop is passed toCardChecklist
QA
Additional context
Testing instructions
CustomHeighttest story added