Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea props cols, size and tooltipMessage don't appear to have any effect #6107

Closed
1 task done
clheppell opened this issue Jun 9, 2023 · 3 comments · Fixed by #6735
Closed
1 task done

Textarea props cols, size and tooltipMessage don't appear to have any effect #6107

clheppell opened this issue Jun 9, 2023 · 3 comments · Fixed by #6735

Comments

@clheppell
Copy link

Current behaviour

When trying to set cols or size to control the appearance of the Textarea, nothing happens, though I can see from your code that they are passed further down.

Setting tooltipMessage has no impact - looking at code I can see it in the type definition but nowhere else - not sure if there are any other tooltip related props that do/don't work.

Expected behaviour

Props either work or shouldn't be listed.

CodeSandbox or Storybook URL

https://codesandbox.io/s/fragrant-silence-d9f2c6?file=/src/App.js

JIRA Ticket (Sage Only)

No response

Suggested Solution

No response

Carbon Version

116.2.0

Design Tokens Version

No response

What browsers are you seeing the problem on?

Firefox, Chrome

What Operating System are you seeing the problem on?

Windows

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@clheppell clheppell added Bug triage Triage Required labels Jun 9, 2023
@edleeks87
Copy link
Contributor

https://codesandbox.io/s/weathered-fire-4lc3qy?file=/src/App.js

Not really clear why tooltipMessage is surfaced on this tbh as we have the props needed to set the relevant messages on the help or validation icons

@DipperTheDan
Copy link
Contributor

FE-6009

@DipperTheDan DipperTheDan added On Backlog textarea and removed triage Triage Required labels Jun 13, 2023
nineteen88 added a commit that referenced this issue May 16, 2024
nineteen88 added a commit that referenced this issue May 22, 2024
nineteen88 added a commit that referenced this issue May 22, 2024
BREAKING CHANGE: removed cols, size and tooltipMessage props from the TextArea
component as they were no longer doing anything

fix #6107
carbonci pushed a commit that referenced this issue May 24, 2024
## [136.0.0](v135.1.3...v136.0.0) (2024-05-24)

### ⚠ BREAKING CHANGES

* **textarea:** removed cols, size and tooltipMessage props from the TextArea
component as they were no longer doing anything

### Features

* **textarea:** remove redundant props ([21a701c](21a701c)), closes [#6107](#6107)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 136.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants