Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs component should have a color / backgroundcolor prop #6724

Open
1 task done
sagemihir opened this issue May 7, 2024 · 4 comments
Open
1 task done

Breadcrumbs component should have a color / backgroundcolor prop #6724

sagemihir opened this issue May 7, 2024 · 4 comments

Comments

@sagemihir
Copy link

Description

Breadcrumbs component should have a color / backgroundcolor prop for the dark background screens

Suggested solution

Additional prop for color/background color

For example:
image

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@sagemihir sagemihir added Enhancement triage Triage Required labels May 7, 2024
@nineteen88
Copy link
Contributor

@ljemmo Breadcrumbs don't have a dark variant like links do but effectively they are just links, right? Should we make changes to Breadcrumbs to follow suit?

@ljemmo
Copy link
Contributor

ljemmo commented May 7, 2024

@nineteen88 Makes sense on my side!

@clairedenning FYI we should probably support on dark breadcrumbs in the fusion DS.

@clairedenning
Copy link

clairedenning commented May 13, 2024

Can I ask to see an example of somewhere that needs breadcrumbs on a dark bg please, I'm available on slack or teams? @sagemihir

@edleeks87
Copy link
Contributor

I think it would still be good to get some examples of what's wanted here, @sagemihir would you mind sharing them with the carbon and DS teams on slack please? We currently omit certain props from the LinkProps interface before extending them in the CrumbProps interface which we can make changes to to free up support for rendering on dark backgrounds. However, there are other elements rendered as part of this component so we would need to know if they also need styles updated in this scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants