Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form in a Dialog Fullscreen with disableContentPadding #6719

Closed
1 task done
gusch opened this issue May 7, 2024 · 2 comments · Fixed by #6742
Closed
1 task done

Form in a Dialog Fullscreen with disableContentPadding #6719

gusch opened this issue May 7, 2024 · 2 comments · Fixed by #6742
Labels
Bug dialog-full-screen On Backlog released Squad Petrus

Comments

@gusch
Copy link
Contributor

gusch commented May 7, 2024

Description

I have a DialogFullScreen with disableContentPadding.
If I place a Form with stickyFooter DIRECTLY in the dialog, everything is ok.
If I place the Form in another file, i have a horizontal scrollbar

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-havq6t?file=src%2FApp.tsx,src%2FDialogForm.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

133.0.0

Design tokens version

4.34.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@gusch gusch added Bug triage Triage Required labels May 7, 2024
@nineteen88
Copy link
Contributor

nineteen88 commented May 7, 2024 •
edited by Parsium
Loading

FE-6570

Parsium added a commit that referenced this issue May 22, 2024
@Parsium
fix(dialog-full-screen): prevent horizontal overflow due to a child F…
48b7cca 
…orm with a sticky footer

fix #6719
Parsium added a commit that referenced this issue May 22, 2024
@Parsium
fix(dialog-full-screen): prevent horizontal overflow due to a child F…
b1b3a7b 
…orm with a sticky footer

fix #6719
@Parsium Parsium mentioned this issue May 22, 2024
Merged
14 tasks
Parsium added a commit that referenced this issue Jun 4, 2024
@Parsium
fix(dialog-full-screen): prevent horizontal overflow due to a child F…
4fea1d5 
…orm with a sticky footer

fix #6719
carbonci pushed a commit that referenced this issue Jun 5, 2024
@semantic-release-bot @carbonci
chore(release): 136.0.3
6c318cd 
### [136.0.3](v136.0.2...v136.0.3) (2024-06-05)

### Bug Fixes

* **dialog-full-screen:** prevent horizontal overflow due to a child Form with a sticky footer ([4fea1d5](4fea1d5)), closes [#6719](#6719)
@carbonci
Copy link
Collaborator

carbonci commented Jun 5, 2024

🎉 This issue has been resolved in version 136.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug dialog-full-screen On Backlog released Squad Petrus
Milestone
No milestone
3 participants
@gusch @carbonci @nineteen88