Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sui-pde] avoid tracking Experiment Viewed on feature flags #1601

Closed
alextremp opened this issue May 4, 2023 · 0 comments
Closed

[sui-pde] avoid tracking Experiment Viewed on feature flags #1601

alextremp opened this issue May 4, 2023 · 0 comments

Comments

@alextremp
Copy link
Collaborator

Package

pde

Description

Currently when we request for a feature flag to be active or not, if the user was not assigned to an optimizely response, we always track to Segment the Experiment Viewed event.

We have a request to avoid that as much as we can to avoid consuming Segment API Calls when there's no analytic interest on the feature flags.

As a proposal, and following a previous open issue to use structured args in useFeature ( #1418 ), we should add an additional arg to the useFeature:

  • track: Boolean, false by default. Setting it to true would mean there is a specific analytic interest on a feature flag and it should track the Experiment Viewed event. Letting it to false, it should not track the event to Segment.

Note that this would mean to push a Major version or send a clear notification about the change to current PDE users as the default tracking behavior will change.

Expected behavior: Only track the Experiment Viewed events to Segment if the new track parameter is explicitly set to true into the useFeature parameters

Actual behavior: Experiment Viewed events are always tracked to Segment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant