Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨AtomButton: the returned button children structure might never change #2341

Open
andresin87 opened this issue Sep 30, 2022 · 4 comments
Open

✨AtomButton: the returned button children structure might never change #2341

andresin87 opened this issue Sep 30, 2022 · 4 comments
Labels
hacktoberfest refactor code refactor

Comments

@andresin87
Copy link
Member

Is your iteration request related to a problem?

No response

Describe the solution you'd like

The resulting html inner structure might be always the same

Screenshots

No response

Additional context**

No response

Additional info

No response
@andresin87 andresin87 self-assigned this Sep 30, 2022
@andresin87 andresin87 removed their assignment Sep 30, 2022
@Abhirv08
Copy link

Abhirv08 commented Oct 1, 2022

@andresin87 can you specify which AtomButton you are talking about?

@andresin87
Copy link
Member Author

andresin87 commented Oct 1, 2022 •
edited
Loading

components/atom/button/src/index.js

@andresin87
Copy link
Member Author

The not isLoading return ternary part has a conditionaly erapper depending on if the component has or not a left/right icon. The idea is to aleays wrap the children with this element, nos changing the dom structure

@rparthas
Copy link
Contributor

@andresin87 is this open ? Can I work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest refactor code refactor
Projects
Hacktoberfest 2022 🎉
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andresin87 @rparthas @Abhirv08