-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch of KeyPress
event throws a System.AccessViolationException
#245
Comments
this is a serious heisenbug in SFML.Net. it cant usually be replicated while debugging but it appears in release builds. |
its also worth mentioning that this same bug may cause |
It might be recommended to stick to CSFML 2.5.2 until SFML.Net has been updated for 2.6 |
if its any consolation, this is the only problem with SFML.NET which we could find. |
i've been facing this same crash on my build. As @uwaaya mentioned, addition of |
Note, that while the change has been merged into master, it doesn't mean that you can now mix the SFML.Net 2.5.x nuget packages with the CSFML 2.6.x nuget packages. Keep the versions aligned to not run into this issue. 😉 |
Just to clarify, this won't happen unless there are multiple SFML.NET projects being worked on, right? If I only use the latest SFML.Net nupkg (built from the current master branch), I don't need to worry about this, right? |
If you build SFML.Net yourself, then you should be okay for this issue. It's just that there's no official SFML.Net 2.6 Nuget package yet, and people seem to be trigger happy on the update button for CSFML 😄 |
in our case, this actually had nothing to do with nuget. upstream changed the CSFML version, and we just ran into this issue bc we just assumed upstream wouldnt break their master branch. its no big deal though. ppl simply gotta reset to a stable tag after creating their fork, but most would not be aware of that.. this is just my thoughts, but i think it be a good idea to have a development branch for updating CSFML, right? i know its not needed most of the time, but SFML will change a lot with SFML 3 being in active development, and keeping master stable would be super helpful for anybody creating and maintaining their own forks 👀 |
Merging between some We will be adopting the branching as done in SFML and CSFML, where any fixes for SFML.Net will happen on the 2.6.x branch, while master starts targeting SFML 3. As such, since you most likely would want to stick to SFML 2 for a while longer, you can simply target |
Issue description
While running a
RenderWindow
instance, anyKeyPress
event results in throwing aSystem.AccessViolationException
.How to reproduce
Run the example project in
example/window
, and press any keyExpected behaviour
The key is processed by the event successfully
Actual behaviour
An uncaught exception interrupts the program, with the following message on the console.
The text was updated successfully, but these errors were encountered: