Image display deeper only on iOS 17.0

[wgywgy]

Issue Info

Info	Value
Platform Name	ios
Platform Version	17.0
SDWebImage Version	5.18.0
Integration Method	cocoapods
Xcode Version	Xcode 15
Repro rate	all the time (100%)

Issue Description and Steps

Image display deeper only on iOS 17.0(and 17.0.1)
the code is:
CGSize thumbnailSize = CGSizeMake(100, 100);
[_imgView sd_setImageWithURL:[NSURL URLWithString:@"https://raw.githubusercontent.com/wgywgy/picTest/master/222.png"]
placeholderImage:nil
options:0
context:@{SDWebImageContextImageThumbnailPixelSize : @(thumbnailSize)}];

The problem code is in SDImageIOAnimatedCoder 269 line:
imageRef = CGImageSourceCreateThumbnailAtIndex(source, index, (__bridge CFDictionaryRef)[decodingOptions copy]);
It same like ios 17 change the implement. replace with:
imageRef = CGImageSourceCreateImageAtIndex(source, index, (__bridge CFDictionaryRef)[decodingOptions copy]);
The problem is gone.

[dreampiggy]

Provide a reproducable demo ?

[wgywgy]

The code can reproducable:
CGSize thumbnailSize = CGSizeMake(100, 100);
[_imgView sd_setImageWithURL:[NSURL URLWithString:@"https://raw.githubusercontent.com/wgywgy/picTest/master/222.png"]
placeholderImage:nil
options:0
context:@{SDWebImageContextImageThumbnailPixelSize : @(thumbnailSize)}];

[dreampiggy]

The thumbnail is useful, so actually you can not simple change that into CGImageSourceCreateImageAtIndex

If Apple's bug, you'be better fire radar for Apple: https://feedbackassistant.apple.com/

[dreampiggy]

@wgywgy I guess your issue (since you mentioned PNG) is the same as #3605

You can check that firstly and test again (with the avoidDecodedImage), is the behavior still the same ?

[wgywgy]

I try the follow Code (use avoidDecodedImage):

CGSize thumbnailSize = CGSizeMake(100, 100);
[_imgView sd_setImageWithURL:[NSURL URLWithString:@"https://raw.githubusercontent.com/wgywgy/picTest/master/222.png"]
placeholderImage:nil
options:SDWebImageAvoidDecodeImage
context:@{SDWebImageContextImageThumbnailPixelSize : @(thumbnailSize)}];

The behavior still the same

[dreampiggy]

Apple's Bug, not SDWebImage's issue. Fire radar to them :(

TestiOS17PNGThumbnailBug.zip

[dreampiggy]

FB13208254

[dreampiggy]

A quick hack is to disable the thumbnail decoding (Do not pass that thumbnailPixelSize) for iOS 17~iOS 17.1.

[Hoony-HU]

how to fix it

[dreampiggy]

@Hoony-HU If this is iOS system framework ImageIO bug, the only workaround is to disable using thumbnailPixelSize on PNG

Using the ResizeTransformer with your thumbnail size, and do full decoding.

Transformer: https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#image-transformer-50

This may workaround the issue.

However, you MUST upgrade to v5.18.5+, that version contains a hacky workaround for full image decoding on PNG.

https://github.com/SDWebImage/SDWebImage/releases/tag/5.18.5