Improve conversion to BuildError #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the conversion of another exception to a BuildError could yield undesired results: if the exception was a OSError/IOError, and some fields were initially set to None, then the return code and error string were set to None, rather than the SCons defaults (which are return code 2, and the string set originally in the exception). A unit test is added which attempts to build an OSError in the way that the case "in the wild" does - confirmed failing to pick up defaults without the change. Fixes SCons#4530 Signed-off-by: Mats Wichmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the conversion of another exception to a
BuildErrorcould yield undesired results: if the exception was aOSError/IOError, and some fields were initially set toNone, then the return code and error string were set toNone, rather than the SCons defaults (which are return code 2, and the string set originally in the exception).A unit test is added which attempts to build an
OSErrorin the way that the case "in the wild" does - confirmed failing to pick up defaults without the change.Fixes #4530
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)