Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor binomial to binary in tests/ and csep.core/binomial_evaluations.py #216

Open
wsavran opened this issue Apr 4, 2023 · 0 comments
Open

Refactor binomial to binary in tests/ and csep.core/binomial_evaluations.py #216

wsavran opened this issue Apr 4, 2023 · 0 comments
Assignees
@fabiolsilva @pabloitu

Comments

@wsavran
Copy link
Collaborator

wsavran commented Apr 4, 2023

To avoid confusion, we should refactor TestBinomialLikelihood in tests/test_evaluations.py to TestBinaryLikelihood and the module name binomial_evaluations.py to binary_evaluations.py.

This will require changing any imports to other modules and in the __init__.py. Recommended to use an IDE to refactor this to find all usages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiolsilva fabiolsilva

@pabloitu pabloitu

Labels
None yet
Projects
pyCSEP v0.6.3 Release
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabiolsilva @wsavran @pabloitu