Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: fiori/BarcodeScannerDialog Support customizable dialog design #8919

Open
1 task done
slin-sap opened this issue May 8, 2024 · 2 comments
Open
1 task done

Comments

@slin-sap
Copy link

slin-sap commented May 8, 2024

Feature Request Description

BarcodeScannerDialog has a footer and cancel button built-in.

Our designer has different design. It would help if BarcodeScannerDialog also supports slots to accept customizable dialog appearance.

Proposed Solution

  • Support optional custom-header and custom-footer slots
  • When custom-footer slot is present, the default footer slot will not be rendered.
  • Version 2.0 implementation no longer expose close() method. Hopefully the equivalent API still exist that can be used to trigger close from customized close/cancel button. Also trigger close on listening to "scan-success" event.

Proposed Alternatives

No response

Organization

UX Engineering

Additional Context

No response

Priority

Medium

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@niyap niyap self-assigned this May 9, 2024
@niyap niyap removed their assignment May 9, 2024
@niyap niyap added this to Issues in Maintenance - Topic P via automation May 9, 2024
@niyap
Copy link
Contributor

niyap commented May 9, 2024

Hello @SAP/ui5-webcomponents-topic-p,

Could you please take a look of that feature request?

Thank you in advance!

Kind Regards,
Niya

@jdichev jdichev self-assigned this May 14, 2024
@jdichev
Copy link

jdichev commented May 14, 2024

Team will look into this request. Internal reference: BGSOFUIPIRIN-6560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants