Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations #76

Open
mamiksik opened this issue Nov 8, 2019 · 1 comment
Open

Type annotations #76

mamiksik opened this issue Nov 8, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mamiksik
Copy link
Contributor

mamiksik commented Nov 8, 2019

I suggest that all future code should be type annotated and I also suggest adding MyPy to CI. This will make the code easier to read for users as well as maintainers, prevent unnecessary errors and generally make code hinting much more accurate.

References:
PEP 484 -- Type Hints => https://www.python.org/dev/peps/pep-0484/
MyPy => https://github.com/python/mypy

@phanak-sap phanak-sap added the enhancement New feature or request label Apr 27, 2020
@phanak-sap
Copy link
Contributor

Note: Current list of type checkers in Python to choose from is: Mypy, Pyre, Pyright.

As (perhaps practical, not exact) alternative to marking the code with type annotations, one can introduce also mutation testing on top of current unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants