Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Request in Batch Mode, need header #65

Open
ChengQian1007 opened this issue Oct 10, 2019 · 1 comment
Open

Delete Request in Batch Mode, need header #65

ChengQian1007 opened this issue Oct 10, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@ChengQian1007
Copy link

Hello,

when we run delete requests in Batch Mode, it raises an exception:

...service.py", line 57, in encode_multipart
for hdr, hdr_val in req.get_headers().items():
AttributeError: 'NoneType' object has no attribute 'items'

So we need to define the get_header() method for EntityDeleteRequest(ODataHttpRequest), e.g. like this:

def get_headers(self):
return {'Accept': 'application/json'}

I would like to pull a request and do the bugfix.

@filak-sap
Copy link
Contributor

@mamiksik PTAL

@filak-sap filak-sap added issue with PR we have a PR for the issue bug Something isn't working labels Oct 21, 2019
@phanak-sap phanak-sap removed the issue with PR we have a PR for the issue label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants