Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement request to support "upsert" function import from SAP SuccessFactors API #206

Open
alex-berezin opened this issue Feb 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@alex-berezin
Copy link

alex-berezin commented Feb 23, 2022

Hi there,

Can you please consider a new enhancement to support "upsert" function import coming from SAP SuccessFactors API?

Metadata:

FunctionImport< Name="upsert" ReturnType="Collection(SFOData.UpsertResult)" EntitySet="UpsertResult" m:HttpMethod="POST" sap:support-payload="true" >/FunctionImport<"

Example payload:
Method: POST https://api2preview.sapsf.eu/odata/v2/upsert
Body: {
"__metadata": {
"uri": "FormPMReviewContentDetail(formContentId=169736L,formDataId=32107L)",
"type": "SFOData.FormPMReviewContentDetail"
},
"competencySections": [
{
"__metadata": {
"uri": "FormCompetencySection(formContentId=169736L,formDataId=32107L,sectionIndex=1)",
"type": "SFOData.FormCompetencySection"
},
"competencies": [
{
"__metadata": {
"uri": "FormCompetency(formContentId=169736L,formDataId=32107L,itemId=13550L,sectionIndex=1)",
"type": "SFOData.FormCompetency"
},
"officialRating": {
"__metadata": {
"uri": "FormUserRatingComment(formContentId=169736L,formDataId=32107L,itemId=13550L,ratingType='official',sectionIndex=1,userId='admin')",
"type": "SFOData.FormUserRatingComment"
},
"ratingKey": "wf_sect_1__c13550_r",
"rating": "1.0"
}
}
]
}
]
}

@phanak-sap phanak-sap added the V4 OData V4 label Feb 27, 2022
@phanak-sap
Copy link
Contributor

Hi,
the UPSERT feature was new in OData spec version 4. This enh. request is basically subtask of issue #39.

@alex-berezin
Copy link
Author

alex-berezin commented Feb 27, 2022

Hi @phanak-sap ! Well, not sure if it’s part of V4 release, but it’s being used in V2 as Import Function, as you can see from metadata. Probably this is a part of SAP Success Factors API. The main difference is that method is POST for an Import Function, not a GET. So, if possible, please consider it as a V2 part.
It was already requested couple of years ago, see #136 - item 2.

@phanak-sap phanak-sap added enhancement New feature or request and removed V4 OData V4 labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants