Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODataHttpRequest : headers inherited from the connection arg are not handled #108

Open
jblaval opened this issue Jun 23, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jblaval
Copy link

jblaval commented Jun 23, 2020

When executing a request with pyodata's Client, one may need to use some headers, for example for authentication purpose. ODataHttpRequest takes both a Connection argument and a headers keyword-argument, whereas Connection object might already have a headers attribute.
Hence, ODataHttpRequest's init() should merge headers from Connection and from args, overriding the first with the second if necessary.

@phanak-sap phanak-sap added the enhancement New feature or request label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants