-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to retrieve destination properties in mail-client #4425
Labels
feature request
Requests for new functionality
Comments
Hi @PPG-BrianChan , Thanks for raising this. I was able to reproduce this. I'll create a ticket for this in our backlog and update you once we have a fix. |
deekshas8
added
feature request
Requests for new functionality
and removed
bug
Something isn't working
labels
Jan 22, 2024
Hey @deekshas8, we ran into the same issue. Greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear experts,
We are attempting to send mails using the mail-client package. However,Mail destination information required such as host and port cannot be retrieved during execution.
This is because in the source code https://github.com/SAP/cloud-sdk-js/blob/main/packages/mail-client/src/mail-client.ts#L54-L69, it is retrieving the values from "originalProperties", but in reality there is an additional property "destinationConfiguration" encapsulating the values.
To Reproduce
Configure a mail destination in subaccount with mail.host, mail.port and other required information in additional properties. A sample we used is https://help.sap.com/docs/build-process-automation/sap-build-process-automation/configuring-smtp-mail-destination?version=Cloud
Prepare a CAP project and include the mail-client package.
Pass the destination name into the function "sendMail" along with simple mail config.
Execute
Execute CAP project in hybrid testing or deployed mode.
Confirm
Error message will be caught.
See error
Error will be logged as attached in screenshots.
Screenshots
Error log:
Destination Configurations:
Used Versions:
node -v
: v18.14.2npm -v
: 9.5.0"@sap-cloud-sdk/mail-client": "^3.10.0",
"@sap/cds": "^7",
"@sap/xssec": "^3",
Impact / Priority
We intend of making use the same package in all applications that will be sending mails but currently have to resort to a custom solution.
Affected development phase: Development
Impact: Impaired
Additional context
A similar issue is raised in the comment of the blog https://blogs.sap.com/2023/02/14/connecting-on-premise-mail-destination-using-sap-cloud-sdk-javascript-version-3-on-sap-cap/
FYI the same destination can be used by SBPA.
The text was updated successfully, but these errors were encountered: