Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and add a pipeline that runs the checker #301

Open
Oppen opened this issue Jun 12, 2021 · 2 comments
Open

Fix formatting and add a pipeline that runs the checker #301

Oppen opened this issue Jun 12, 2021 · 2 comments

Comments

@Oppen
Copy link
Collaborator

Oppen commented Jun 12, 2021

The title is self-descriptive. Many files fail the clang-format-check.sh, discouraging using clang-format.sh to keep the newer patches in shape.
Fixing is easy, a single commit per-file for easy revision, and I can do that easily.
The second part is about preventing getting to that state again. The pipeline should run clang-format-check.sh. As I'm not admin for the repo, I can only suggest it.

@Oppen
Copy link
Collaborator Author

Oppen commented Jun 21, 2021

Soooo, this actually can be done by me in a PR. I didn't know that.

@lemire
Copy link
Member

lemire commented Jun 21, 2021

@Oppen As far as GitHub actions, you can indeed propose something.

It makes little difference whether one is 'admin' or not, actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants