Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Users component on the right hand side #21

Open
Rishabh-malhotraa opened this issue Mar 24, 2021 · 4 comments
Open

Fix Users component on the right hand side #21

Rishabh-malhotraa opened this issue Mar 24, 2021 · 4 comments
Assignees
Labels
bug 🐛 Something isn't working good first issue Good for newcomers

Comments

@Rishabh-malhotraa
Copy link
Owner

Rishabh-malhotraa commented Mar 24, 2021

Describe the bug
Desgin flaw first I capped the room limit to 2 people but then later I increased it to 5, but I did not change this component, also I want to show random user icon images rather than just guest user icon, because then you cannot distinguish between users.

image

To fix :
Correct the socket-io code so it sends data of all the users in the room rather than the person who was last to join
files:

caucus-server/src/service/socket-io-service.ts

And manage the front end part too:

caucus/src/components/VoiceChat
caucus/src/pages/room/room.tsx
@Rishabh-malhotraa Rishabh-malhotraa added bug 🐛 Something isn't working good first issue Good for newcomers labels Mar 24, 2021
@Rishabh-malhotraa Rishabh-malhotraa pinned this issue Jun 20, 2021
@deepanshu2506
Copy link

@Rishabh-malhotraa assign it to me.. i'll work on this

@Rishabh-malhotraa
Copy link
Owner Author

This is a complicated issue because of bad architectural design, but it shouldn't be that hard to fix. I'll assign you this issue, hmu on discord is you face any issue.

@deepanshu2506
Copy link

is there a env file for the server?

@Rishabh-malhotraa
Copy link
Owner Author

is there a env file for the server?

It is mentioned in the prerequisites.
https://github.com/Rishabh-malhotraa/caucus-server#installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants