New: Optionally use Environment Variables for settings in config.xml #3482
Conversation
|
I'll take a look at what work implies pulling |
|
FYI this needs to close #3496 as well. |
|
I would like to thank @sillock1 for taking time to implement this feature for *arr apps. It would be really great to see these changes merged to have feature parity between all major *arr apps. Right now, I'm working on new modules for NixOS utilizing these changes and have a working prototype for all other apps but planning to wait until all apps have this functionality at stable/main version. |
|
Best you can expect from Readarr is a develop release. |
No problem with that. I didn't know that Readarr didn't have stable release yet and was looking at Sonarr with their main vs. develop version split. NixOS/Nixpkgs use develop releases of Readarr anyway. |
I've pulled that commit into this PR |
What was your verdict on this? |
|
Didn't looked into it since I'm taking a break. 😺 |
|
Just pushed it, feel free to rebase. |
mynameisbogdan
force-pushed
the
env-config
branch
from
4e18596
to
6be535b
Compare
|
Thanks for your contribution. |
Database Migration
NO
Description
Pulled from upstream https://github.com/Sonarr/Sonarr/pull/6746/files
The auth required option hasn't been brought over as the
UiAuthorizationHandlerwasn't originally pulled downstream like the other arrs. Not sure if this was intentional or whether it just happened to be missed.