Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

TypeScript definition file #18

Open
dubiousdavid opened this issue Nov 5, 2014 · 11 comments
Open

TypeScript definition file #18

dubiousdavid opened this issue Nov 5, 2014 · 11 comments

Comments

@dubiousdavid
Copy link

No description provided.

@mattpodwysocki
Copy link
Member

@Igorbek any plans on making one for this project?

@Igorbek
Copy link

Igorbek commented Jan 6, 2015

I'll arrange my plan to make it this week (or, probably, the following week).

@kseo
Copy link
Contributor

kseo commented Jul 12, 2015

@Igorbek It seems the type definition file is still missing. Would you mind if I work on it?

@crissdev
Copy link
Contributor

I've created one but I'm not sure about it. https://gist.github.com/crissdev/56fda2b80011093e0171


EDIT Updated Typescript definition file with what's currently documented.

@mattpodwysocki
Copy link
Member

@david-driscoll Could you by chance help me with the TS typings for RxJS-DOM?

@david-driscoll
Copy link

Sure, if I have time tonight I'll work on this one.

On Mon, Oct 5, 2015 at 10:40 AM, Matthew Podwysocki <
[email protected]> wrote:

@david-driscoll https://github.com/david-driscoll Could you by chance
help me with the TS typings for RxJS-DOM?


Reply to this email directly or view it on GitHub
#18 (comment)
.

@oliverw
Copy link

oliverw commented Oct 26, 2015

@david-driscoll
Copy link

Nice! I can review if needed in a day or two (depends if I find time while
in Dallas )

On Mon, Oct 26, 2015 at 9:29 AM Oliver Weichhold [email protected]
wrote:

Here's my take: https://gist.github.com/oliverw/a3ba9d804d848417fac4


Reply to this email directly or view it on GitHub
#18 (comment)
.

Thanks,
David

@kfei
Copy link

kfei commented Dec 15, 2015

@oliverw, thank you for the def file! Would you please consider submit it to DefinitelyTyped so that everyone can benefit from it?

@david-driscoll, any thoughts on the definition file? Thanks.

@david-driscoll
Copy link

only comment would be that the definitions like

 function blur(element: Element, selector?:Function, useCapture?:boolean):Rx.Observable<FocusEvent>;

assuming selector modifies the value sent out as the observable, they could be broken out into...

 function blur(element: Element): Rx.Observable<FocusEvent>;
 function blur<T>(element: Element, selector?: (e: FocusEvent) => T, useCapture?:boolean): Rx.Observable<T>;

@doubleppereira
Copy link

I am trying to use your version @oliverw, I am doing:
import { DOM } from 'rx';

It's always undefined.
Have you guys had any problems with this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants