Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Documentantion of Rx.DOM.ajax is incorrect #137

Open
dmnrmr opened this issue Jan 21, 2018 · 2 comments
Open

Documentantion of Rx.DOM.ajax is incorrect #137

dmnrmr opened this issue Jan 21, 2018 · 2 comments

Comments

@dmnrmr
Copy link

dmnrmr commented Jan 21, 2018

It says that you either pass a url: string or a settings: Object when in reality it is this:

get(url: string, headers?: Object): Observable<AjaxResponse>;

Also how can you set responseType (which defaults to json) when you can't pass any options?

@whiteinge
Copy link
Contributor

The docs are correct: https://github.com/Reactive-Extensions/RxJS-DOM/blob/35271e7/src/ajax/ajax.js#L220-L228

If you need to specify responseType then you'll need to pass an object and not a string.

@dmnrmr
Copy link
Author

dmnrmr commented Jan 22, 2018

It was very stupid of me trying to pass settings to ajax.get method. Case closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants