-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Refresh Animation): Improve the refreshing animation #1568
Comments
@Domenic-MZS, maybe you can look into this one? |
Sorry for the delay, @ILoveOpenSourceApplications. I've been a bit busy lately. Yup, I'd like to try this one. Let me handle this issue. TL;DR Long VersionI think the ReVanced dashboard is using the Because the RefreshIndicator by default wraps the custom scroll in its extent, and has an edge property of 0 (which starts showing the indicator in that position), the indicator starts at the start, on the topmost position of the custom scroll (having the appbar and content )
|
Feature description
When refreshing
Dashboard
, the refresh animation that shows up is an incomplete circle animation instead of the traditional circling cycle animation on every other apps. (Don't judge me for phrasing it this way.)What ReVanced Manager does:
screen-20231016-004038.2.mp4
What it should be doing:
screen-20231016-004355.3.mp4
Also, the refresh icon starts showing up all the way from the notification shade instead of showing up within the manager. It should start from the point in the
Dashboard
where the padding is when scrolling down.Without scrolling:
When scrolled down a bit:
The refresh icon should start after the padded area of
Dashboard
, like it's coming from underneath the padded area.Motivation
I checked out the examples provided in the repository and
MaterialClassicHeader
seems to be the one which was implemented in ReVanced Manager (or looks like what was intended). Correct me if I'm wrong.P.S: Attaching the gif for further clarity
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: