Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-ProjectName fails when alias git exists #136

Open
peetrike opened this issue Oct 24, 2022 · 2 comments
Open

Get-ProjectName fails when alias git exists #136

peetrike opened this issue Oct 24, 2022 · 2 comments

Comments

@peetrike
Copy link

peetrike commented Oct 24, 2022

When there is defined alias with name git, the Get-ProjectName command (called without parameters) emits following error message:

The variable cannot be validated because the value $null is not a valid value for the GitPath variable.
At C:\Program Files\WindowsPowerShell\Modules\BuildHelpers\2.0.16\Public\Get-ProjectName.ps1:57 char:9
+         $GitPath = (Get-Command $GitPath -ErrorAction SilentlyContinu ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The command itself works despite the error above.

The error could be avoided when $GitPath variable contains string git.exe or when the get-command has parameter -CommandType Application added at:
https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Get-ProjectName.ps1#L57

@peetrike
Copy link
Author

Also the next line could have parameter -CommandType Application added:
https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Get-ProjectName.ps1#L47

@peetrike
Copy link
Author

The same problematic pattern is also in Invoke-Git command:
https://github.com/RamblingCookieMonster/BuildHelpers/blob/master/BuildHelpers/Public/Invoke-Git.ps1#L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant