-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restarting the same stream #98
Comments
Good point...likely we should allow that. Short answerI wanted to throw an exception if people try to attach to the same port twice and also have an exception for when the runtime itself errs and tries to double allocate things (as a sanity check). It doesn't have to throw an exception at each Longer answerThe graph is built lazily, and by that I mean that nothing is really evaluated aside from connectivity and type until you call exe. So what the exception is saying is that the runtime is trying to allocate another FIFO for something that already has one. Again, I think you're right @mr-j0nes, we should allow the No problem! Keep the questions coming. I'll see if I can get to some of the rest of them. |
Exactly. Now I am trying to implement a recovering logic which requires the stream to be restarted. It does not feel right to have to re-link all kernels while they are already linked and nothing has to change in that area. Good that you also agree, it seems to me that all checks and evaluations should be done at the kernel linking stage rather than in the exe(). Perfect, then I wait until you have a bit more of time. Cheers.. |
HI @mr-j0nes, I'm working on a fix, right now I'm gonna have a check in the |
Hi Jonathan, hope you are doing fine. |
It's in progress. There's shutdown condition that I need to deal with. More specifically, There needs to be a cleaner way of doing "barriers" to wait on the specific kernel that is needed within the main thread of execution. |
I know there is a branch with work on this, but I have work around'ed this by just creating all kernels again in the second run:
|
Hi Jonathan,
very quick question, is there any particular reason why a stream cannot be restarted without initializing the map ? E.g.:
The exception thrown is:
Thanks a lot,
cheers.
The text was updated successfully, but these errors were encountered: