Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悰BUG] Context-aware recommenders not properly embedding float sequences. #2043

Open
mmosc opened this issue May 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mmosc
Copy link

mmosc commented May 5, 2024

Hello!
Thank you for this library.

Describe the bug
I am running several context-aware models using several float-sequence item features. However, the results that I get are for each model always the same, irrespective of the feature loaded.

While inspecting the code of Context Aware recommenders, I noticed that float sequences are always embedded with a number of embeddings of float_seq_field_dim. However, float_seq_field_dim is always 1 for float sequences, as can be seen here and here. This means that every item is assigned the same embedding. This would explain why I get the same result, no matter which item feature I am loading.

Expected behavior
The model performance should vary depending on the float seq feature used.

My guess on the origin of the problem
float sequences are always embedded with a number of embeddings of 1, which means that every item is assigned the same embedding. This would explain why I get the same result, no matter which item feature I am loading.

Are my hypotheses correct? If so, I think I found a bug :)

Best,
Marta

@mmosc mmosc added the bug Something isn't working label May 5, 2024
@mmosc
Copy link
Author

mmosc commented May 29, 2024

Hello!

Are there any updates on this?

Best,
Marta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants