-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] URL Tests can optionally check for presence of a specified string #352
Comments
Interesting idea |
It's done on my fork. Pending a pull request but not sure how to handle this with my previous pull request. Should I branch from my branch or start from master? |
Awesome! Ideally, start from master, but if you want to branch from your roles branch that works as well but I won't be able to merge it until the other branch is, then I imagine there will be merge conflicts |
Yeah, that's the point. I've started from master but there are so many changes with my previous PR that it will conflict quite a lot. |
In order to make the URL tests more helpful for ensuring a service is online, it could optionally check for the presence of a string that if the URL works, but the string is not found, it will still consider the test as failed. It could perhaps be a different status to differentiate between the URL not loading, and the string not having been found.
Another tool we use has something similar, and I have attached a screenshot. This is a tool called Pingdom which regularly checks websites, and one of the optional features is to check for a string when it looks at the response from the page.
The text was updated successfully, but these errors were encountered: