Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Skip exsitings/translated keys #6

Open
WeslleyDeSouza opened this issue Feb 13, 2024 · 7 comments
Open

Feature: Skip exsitings/translated keys #6

WeslleyDeSouza opened this issue Feb 13, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@WeslleyDeSouza
Copy link

WeslleyDeSouza commented Feb 13, 2024

We are using various Locale files, and some of them already contain many translations. It would be great if we could control via a property whether the keys that are already translated should not be translated again, but only the keys that do not exist or are empty.
This would save API requests, as the already translated keys could be skipped.

@Quilljou Quilljou added the enhancement New feature or request label Feb 13, 2024
@Quilljou Quilljou self-assigned this Feb 13, 2024
@Germey
Copy link
Contributor

Germey commented Mar 25, 2024

@WeslleyDeSouza same issue, so I raise a PR to improve it: #9, cc @Quilljou please help review.

@Quilljou
Copy link
Owner

Version upgraded to 0.4.0. Give it a try.

Thanks @Germey

@WeslleyDeSouza
Copy link
Author

WeslleyDeSouza commented Apr 3, 2024

@Germey Thanks alot for your PR/Changes :)

I found a issue in v0.4.0:
image

PR:
image

Are you creating a cache per file or per key?
image

I think the documentation (README.md) needs to be updated.
Additionally, it would be helpful if the final log could print the skipped files.
For example:

Skipped: 30

image

fyi @Quilljou

@Germey
Copy link
Contributor

Germey commented Apr 5, 2024

For response_json params, I think OpenAI API should support it, what model does you use?

And yes, every file will create a cache file, so that to remove the multi-write issue at same time.

For docs, @Quilljou could you please help update?

@WeslleyDeSouza
Copy link
Author

@Germey im using the default model.
image

@Quilljou
Copy link
Owner

Quilljou commented Apr 6, 2024

@WeslleyDeSouza Updated the default model to the latest. Now would be fine at 0.4.1

@Quilljou
Copy link
Owner

Quilljou commented Apr 6, 2024

Hard to know which model supports the json_object response. I removed this attribute in version 0.4.2 @WeslleyDeSouza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants