Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column height Inheritance and text spacing #863

Open
blogcraft opened this issue Apr 26, 2024 · 1 comment
Open

Column height Inheritance and text spacing #863

blogcraft opened this issue Apr 26, 2024 · 1 comment

Comments

@blogcraft
Copy link

Describe the bug
I noticed 2 issues when I migrated from 2023.6.0 to 2024.3.1

  1. It seems there is a problem with how height is trespassed from a parent component to a child in a column.

Example:
When implementing a chart, the canvas receives now a 0 height. So, my chart "dissapears" This happens only in Linux.
image

So, I had to change the parent container to pass the height directly because now is not "inherited (?)". The container used to have a 170 height, but now I just leave 110 to the chart, the padding has 20x2 and the Label component has internal 20 height.
image

This used to work fine with previous version. So, I don't know if this is a bug or an intentional change.

  1. Also, there is some notable differences in how text is rendered because spacing has dramatically changed.

Before (had better spacing):
image

After (now seems space above disappeared):
image

Environment
What version of the library do you use? upgrading from 2023.6.0 to 2024.3.1

What operating system do you use? (OS type, x64 vs x86 vs arm64)
The height inheritance problem only happens in Linux. (tested using WSL and Azure App Service Linux)
The text spacing happens in Windows and Linux

@MarcinZiabek
Copy link
Member

Thank you for finding those problems 😄

It seems there is a problem with how height is trespassed from a parent component to a child in a column.

Indeed! I identified and fixed the root cause in the 2024.3.2 release. Would you please try it?

Also, there is some notable differences in how text is rendered because spacing has dramatically changed.

I am sorry for this particular problem. The text rendering engine has been rebuilt from the ground up, to achieve better compliance with all standards. Your observation is truly a bug, and is being actively discussed in this thread: #860 (comment)

The root cause is already known, and I am working on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants