Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect nuget package QuestPDF 2024.3.0-rc2 #831

Open
nsalikhov opened this issue Apr 2, 2024 · 0 comments
Open

Incorrect nuget package QuestPDF 2024.3.0-rc2 #831

nsalikhov opened this issue Apr 2, 2024 · 0 comments

Comments

@nsalikhov
Copy link

Describe the bug
We are investigating the issue of high memory consumption in recent versions and it seems that the last nuget package 2024.3.0-rc2 doesn't match with branch https://github.com/QuestPDF/QuestPDF/tree/2024.3.0-rc2 code.

To Reproduce
For example, in class GenerateExtensions there is method GeneratePdf(this IDocument document, Stream stream) which output data to a provided stream directly without copying:

        /// <summary>
        /// Generates the document in PDF format and outputs it to a provided stream.
        /// </summary>
        public static void GeneratePdf(this IDocument document, Stream stream)
        {
            DocumentGenerator.GeneratePdf(stream, document);
        }

but in QuestPDF.2024.3.0-rc2.nupkg there is another code:

        /// <summary>
        /// Generates the document in PDF format and outputs it to a provided stream.
        /// </summary>
        public static void GeneratePdf(this IDocument document, Stream stream)
        {
            var data = document.GeneratePdf();
            stream.Write(data, 0, data.Length);
        }

Expected behavior
Nuget contains actual code.

Screenshots
Nuget package code:
image

Branch code:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant