Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: need method ot collect ALL metrics per request #101

Open
iglov opened this issue Jan 31, 2024 · 4 comments
Open

FR: need method ot collect ALL metrics per request #101

iglov opened this issue Jan 31, 2024 · 4 comments

Comments

@iglov
Copy link

iglov commented Jan 31, 2024

Sup guyz! Thx 4 exporter_exporter! It would be great if you add some method, (4 ex. curl -s "http://our_host:9999/proxy?modules") which we would use to get all metrics we have at once.

@tcolgate
Copy link
Collaborator

This might be possible but is not simple as it requires modifying all the metrics to include a label that would be unique to invocation of the module (otherwise there is likely to be duplication where different modules export the same metric, which violates the prometheus scraping model).

@iglov
Copy link
Author

iglov commented Jan 31, 2024

Hey @tcolgate !
Yeah, i though about that and i believe that should be user responsibility. In other words, i think we should not modifying any metrics, but use the simple principle of deduplication: from several identical metrics we must get the last one (and write warning to logs with metric name). And ofc we write about that behavior in README. How do you think?

@tcolgate
Copy link
Collaborator

Almost all exporters will have some overlap e.g. process_ or language specific bits like go_ metrics. It'd be rare for there to not be some overlap.

@iglov
Copy link
Author

iglov commented Jan 31, 2024

Ohh shooot, sry i forgot about that cuz i always turn off that kind of metrics. We-e-e-ell, i see only 2 ways:

  • Just suppress all of these metics. 4 ex. give a user possibility define a list of metrics he wants to cut off OR some list metrics he only wants to see (blacklist/whitelist).
  • As you said earlier, add to each metric some label (4 ex. get it from config from module name: {module="node_exporter"})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants