-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeginTabItem()
ignores flags if p_open == nil
#4088
Labels
Comments
Also, if it's possible, please update imgui.NET to the latest release. The current version being used by Quaver is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When a tab item is created, there are times when you want to use a flag to override selection. However, in Quaver, this is only possible when
p_open = true
orp_open = false
, both of which are not ideal:p_open = true
creates x's on the tab itemsp_open = false
just removes the tab entirelyWhen
p_open = nil
, the flags are ignored.To Reproduce
settings.ini
you'd like.plugin.lua
:item 2
is not always selected.Expected behavior
Expected behavior occurs when the
nil
is replaced totrue
within the secondimgui.BeginTabItem()
:Log Files
Quaver does not produce plugin logs.
Screenshots
When
item 2
hasp_open = true
:In the above image, it is impossible to select another tab, which is the intended behavior of the code above.
When
item 2
hasp_open = nil
:Notice that
item 1
being selected completely violates the code, as it mandates thatitem 2
be selected at all times. This is the core error.The text was updated successfully, but these errors were encountered: